git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/2] Documentation/log: clarify sha1 non-abbreviation in log --raw

From
Junio C Hamano <gitster@pobox.com>
Date
May 18, 2015, 20:52 UTC
Message-ID
<xmqq4mn9bobv.fsf@gitster.dls.corp.google.com>
In-Reply-To
<1431971758-979-2-git-send-email-Matthieu.Moy@imag.fr>
Matthieu Moy <Matthieu.Moy@imag.fr> writes:
Show 20 quoted lines
> Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
> ---
> This patch is new.
>
>  Documentation/pretty-formats.txt | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/pretty-formats.txt b/Documentation/pretty-formats.txt
> index dcf7429..c434ecc 100644
> --- a/Documentation/pretty-formats.txt
> +++ b/Documentation/pretty-formats.txt
> @@ -79,7 +79,10 @@ stored in the commit object.  Notably, the SHA-1s are
>  displayed in full, regardless of whether --abbrev or
>  --no-abbrev are used, and 'parents' information show the
>  true parent commits, without taking grafts or history
> -simplification into account.
> +simplification into account. Note that this format affects the way
> +commits are displayed, but not the way the diff is shown e.g. with
> +`git log --raw`. To get unabbreviated commits in a raw diff format,
> +use `--no-abbrev`.
s/commits in a raw/object names in a raw/?

I wondered what "this format" was, and had to read the patch with "show -U60" to realize that this is about "--pretty=<format>". Perhaps the introductory text of the first paratraph in the section is not clear enough that not just --pretty=raw but --pretty=anything is about how the commit object is shown and has nothing to do with how patches are shown, and that is why this new text is necessary? It somehow looks out of place to have this description only for 'raw'. I think it is OK because it is hard to imagine how other formats would affect patch output ("git log --pretty=<any>" would not give any patch, "git log --pretty=<any> -p" would always give textual patch and not diff-tree raw patch), but it is possible to confuse between '--pretty=raw' and '--raw'.

Thanks.
Previous: Matthieu MoyNext: Matthieu Moy
Message 14 of 16 in “git log --raw abbreviates SHA1s, despite what manual says”
  1. Ed AvisMay 15, 2015
  2. Matthieu MoyMay 15, 2015
  3. Ed AvisMay 15, 2015
  4. Ed AvisMay 15, 2015
  5. Matthieu MoyMay 15, 2015
  6. Documentation/log: clarify what --raw meansMatthieu Moy, May 15, 2015
  7. Ed AvisMay 15, 2015
  8. Junio C HamanoMay 15, 2015
  9. Eric SunshineMay 15, 2015
  10. Junio C HamanoMay 15, 2015
  11. Matthieu MoyMay 18, 2015
  12. 1/2 Documentation/log: clarify what --raw meansMatthieu Moy, May 18, 2015
  13. 2/2 Documentation/log: clarify sha1 non-abbreviation in log --rawMatthieu Moy, May 18, 2015
  14. Junio C HamanoMay 18, 2015
  15. Matthieu MoyMay 18, 2015
  16. Junio C HamanoMay 18, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.