Re: [PATCH 1/3] t5313: test bounds-checks of corrupted/malicious pack/idx files
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 25, 2016, 20:31 UTC
- Message-ID
- <xmqq4mcwo7lb.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <56CF523A.8050208@kdbg.org>
Johannes Sixt <j6t@kdbg.org> writes:
Show 8 quoted lines
> Am 25.02.2016 um 15:21 schrieb Jeff King:
>> +munge () {
>> + printf "$3" | dd of="$1" bs=1 conv=notrunc seek=$2
>> +}
>
> Instead of adding another call of dd, would it be an option to insert
> the following patch at the front of this series and then use
> test_overwrite_bytes?It would be an option, but I'd want to merge this to 'next' today without waiting for a reroll. Change from dd to custom script can be done as a follow-up topic after the dust settles, if necessary.
Thanks.