Re: [PATCH] comment for a long #ifdef

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 4, 2016, 17:54 UTC
Message-ID: <xmqq4mbh5kfp.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <5701BCC1.9050306@mail.mipt.ru>

Ivan Pozdeev <vano@mail.mipt.ru> writes:

> ---
> compat/poll/poll.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

As Eric pointed out, please sign-off your patch.

Show 22 quoted lines

> diff --git a/compat/poll/poll.c b/compat/poll/poll.c
> index db4e03e..5eb0280 100644
> --- a/compat/poll/poll.c
> +++ b/compat/poll/poll.c
> @@ -441,7 +441,7 @@ poll (struct pollfd *pfd, nfds_t nfd, int timeout)
> }
>
> return rc;
> -#else
> +#else /* #ifndef WIN32_NATIVE */
> static struct timeval tv0;
> static HANDLE hEvent;
> WSANETWORKEVENTS ev;
> @@ -622,5 +622,5 @@ restart:
> }
>
> return rc;
> -#endif
> +#endif /* #ifndef WIN32_NATIVE */
> }
> -- 
> 1.9.5.msysgit.1

There also is an #ifndef/#else/#endif in abspath.c that is larger than a typical patch context; could you include a fix for that, too?