Re: [PATCHv3 0/3] Implements the GIT_TRACE_CURL environment variable

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 20, 2016, 18:41 UTC
Message-ID: <xmqq4maww2bk.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160420162825.62380-1-gitter.spiros@gmail.com>

Elia Pinto <gitter.spiros@gmail.com> writes:

> Elia Pinto (3):
>   git.txt: document the new GIT_TRACE_CURL environment variable
>   imap-send.c: introduce the GIT_TRACE_CURL enviroment variable
>   http.c: implements the GIT_TRACE_CURL environment variable

I think 2 & 3 need to be swapped; otherwise 2 would refer to yet-to-be-invented curl_trace() function, and break the build without 3, no?

Strictly speaking 1 should come at the end for the same reason, as setting GIT_TRACE_CURL after seeing that commit would not give users anything new.

Other than that, I didn't find anything blatantly wrong ;-). Will nitpick individual patches later but I expect that it would be sufficient to locally tweak while queuing without rerolling.

Thanks.