Re: [PATCHv2 1/2] submodule init: fail gracefully with a missing .gitmodules file
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 29, 2016, 17:06 UTC
- Message-ID
- <xmqq4mak1h04.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <1461873766-14703-1-git-send-email-sbeller@google.com>
Stefan Beller <sbeller@google.com> writes:
Show 8 quoted lines
> When there is no .gitmodules file availabe to initialize a submodule > from, `submodule_from_path` just returns NULL. We need to check for > that and abort gracefully. When `submodule init` was implemented in shell, > a missing .gitmodules file would result in an error message > > No url found for submodule path '%s' in .gitmodules > > Replicate that error message for now.
Good to start from a faithful conversion. Thanks for adding a test, too.
Will queue.