Re: [PATCH 1/6] i18n: commit: mark message for translation
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 19, 2016, 21:08 UTC
- Message-ID
- <xmqq4m5begxj.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <34292875.FKhN8jTqO5@cayenne>
Jean-Noël AVILA <jn.avila@free.fr> writes:
> Maybe 3/6 would have benefited from some code factorization. But that's ok for > a few more sentences.
Ah, let me see I understood what you mean. Adding something like this
static NORETURN void die_want_option(const char *option_name)
{
die(_("option '%s' requires a value"), option_name);
}and have many of the callers of die() call it would reduce the number of strings that translators would need to touch.
I agree, but I think we can do that in a later follow-up.
Thanks.