git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] merge-recursive: ignore_case shouldn't reject intentional removals

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 27, 2017, 03:40 UTC
Message-ID
<xmqq4lpgfkyb.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20171124195901.2581-1-newren@gmail.com>
Elijah Newren <newren@gmail.com> writes:
Show 17 quoted lines
> In commit ae352c7f3 (merge-recursive.c: fix case-changing merge bug,
> 2014-05-01), it was observed that removing files could be problematic on
> case insensitive file systems, because we could end up removing files
> that differed in case only rather than deleting the intended file --
> something that happened when files were renamed on one branch in a way
> that differed only in case.  To avoid that problem, that commit added
> logic to avoid removing files other than the one intended, rejecting the
> removal if the files differed only in case.
>
> Unfortunately, the logic it used didn't fully implement that condition as
> stated above...
>
> If that description leaves more questions than answers, we may need to
> augment the above commit message with the following explanation...
> ...
>  merge-recursive.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
As a fix, this sorely wants something new in t/ directory.
Previous: Junio C HamanoNext: Elijah Newren
Message 7 of 10 in “merge-recursive: ignore_case shouldn't reject intentional removals”
  1. merge-recursive: ignore_case shouldn't reject intentional removalsElijah Newren, Nov 24, 2017
  2. Eric SunshineNov 24, 2017
  3. Elijah NewrenNov 24, 2017
  4. Junio C HamanoNov 25, 2017
  5. Elijah NewrenNov 25, 2017
  6. Junio C HamanoNov 26, 2017
  7. Junio C HamanoNov 27, 2017
  8. Elijah NewrenNov 27, 2017
  9. Junio C HamanoNov 27, 2017
  10. Elijah NewrenNov 28, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.