Re: [GSoC][PATCH v2] commit: add a commit.signOff config variable

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 5, 2018, 19:22 UTC
Message-ID: <xmqq4lmvb5sz.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180205104059.4759-1-chenjingpiao@gmail.com>

Chen Jingpiao <chenjingpiao@gmail.com> writes:

> Add the commit.signOff configuration variable to use the -s or --signoff
> option of git commit by default.

This is a rather old topic.  Here is one from 2006:

    https://public-inbox.org/git/Pine.LNX.4.63.0611281426311.30004@wbgn013.biozentrum.uni-wuerzburg.de/

which was referred to in another discussion in late 2008:

    https://public-inbox.org/git/20081227070228.6117@nanako3.lavabit.com/
    https://public-inbox.org/git/7vabaijvxl.fsf@gitster.siamese.dyndns.org/

I am not sure if the reasons why the last effort was retracted still apply to this round (the world certainly has changed in the past 10 years); it would be good to explain why this time it is different ;-).

Assuming that the new configuration variable is a desirable thing to add, the change to the code looks OK. Documentation updates may need more thought in the light of past discussions, though.

Thanks.