git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/5] t6036, t6042: use test_line_count instead of wc -l

From
Junio C Hamano <gitster@pobox.com>
Date
May 26, 2018, 23:58 UTC
Message-ID
<xmqq4lium0jg.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20180526010944.9975-1-newren@gmail.com>
Elijah Newren <newren@gmail.com> writes:
Show 21 quoted lines
>> I'd expect that a reader of the commit who cares enough to bother to
>> wonder by looking at the patch and seeing that 2 became 3 would know
>> why already.  And a reader of the resulting file would not know that
>> the 3 used to be 2, and won't be helped by "we used to count to 2,
>> now we have 'out' also counted" that much, especially in the commit
>> log message.  What would help the latter would be to name which
>> three paths we expect to see in the comment (or test against the
>> exact list of paths, instead of using test_line_count).
>>
>>> An alternative to consider would be to add a .gitignore file in the
>>> initial commit to ignore 'out', then the number of untracked files
>>> don't have to be adjusted.
>>
>> I think that is a preferred solution that we've used in ls-files and
>> status tests successfully.
>
> ...except that if we add a .gitignore to each initial commit (we use
> test_create_repo for nearly every test to keep them separable meaning
> we'd have to do this many times), then four lines above we have to
> adjust the number of expected tracked files.  And, for it to work,
> we'd have to add an --exclude-standard flag to ls-files -o.

Yeah, unless the original planned to use the .gitignore mechanism, converting it to use it now will become noisy.

Previous: Elijah Newren
Message 2 of 2 in “Re: [PATCH 2/5] t6036, t6042: use test_line_count instead of wc -l”
  1. Elijah NewrenMay 26, 2018
  2. Junio C HamanoMay 26, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.