git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fsckObjects tests: show how v2.17.1 can exploit downstream

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 1, 2018, 01:42 UTC
Message-ID
<xmqq4linb7vb.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20180531060259.GE17344@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 7 quoted lines
> I haven't tested it, but I suspect that doing multiple fetches could
> result in passing bad objects through a fetch.fsckObjects filter.
> Because the objects aren't quarantined on fetch, and because
> fsck_finish() requires the objects to be installed into place, they may
> ...
> I think in the long run fetch should implement a similar quarantine
> procedure to what happens on push.
Interesting.

I wonder if we can teach quickfetch codepath to notice the presence of fsckObjects, instead of doing a full quarantine. We can easily enumerate those objects that were already in the object database but outside of the reachability chain before we pretend that we fetched them and make them reachable, and check the content integrity of them, no?

Previous: Jeff KingNext: Jeff King
Message 9 of 10 in “fsckObjects tests: show how v2.17.1 can exploit downstream”
  1. fsckObjects tests: show how v2.17.1 can exploit downstreamÆvar Arnfjörð Bjarmason, May 29, 2018
  2. Jeff KingMay 29, 2018
  3. Ævar Arnfjörð BjarmasonMay 29, 2018
  4. Junio C HamanoMay 30, 2018
  5. Jeff KingMay 31, 2018
  6. Ævar Arnfjörð BjarmasonMay 31, 2018
  7. Junio C HamanoMay 30, 2018
  8. Jeff KingMay 31, 2018
  9. Junio C HamanoJun 1, 2018
  10. Jeff KingJun 1, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.