git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t7419: change test_must_fail to ! for grep

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 23, 2019, 02:18 UTC
Message-ID
<xmqq4l00jjbu.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<6b788f92d2ef6f6cdaf6ea9f2bbe448ce19b2f58.1571737787.git.liu.denton@gmail.com>
Denton Liu <liu.denton@gmail.com> writes:
Show 9 quoted lines
> According to t/README, test_must_fail() should only be used to test for
> failure in Git commands. Replace the invocations of
> `test_must_fail grep` with `! grep`.
>
> Signed-off-by: Denton Liu <liu.denton@gmail.com>
> ---
> *sigh* Here's another cleanup patch for 'dl/submodule-set-branch'. It's
> inspired by Eric Sunshine's comments on the t5520 patchset from earlier.
> It's definitely not urgent, though, and can wait for v2.25.0.

True, but they are trivially correct and removes the risk of inexperienced developers copying and pasting this bad pattern to other tests that was added during this cycle, so I think it is a good idea to take it now.

Thanks for being extra careful.
Previous: Denton Liu
Message 2 of 2 in “t7419: change test_must_fail to ! for grep”
  1. t7419: change test_must_fail to ! for grepDenton Liu, Oct 22, 2019
  2. Junio C HamanoOct 23, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.