Re: [PATCH] prefix_path: show gitdir if worktree unavailable

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 3, 2020, 17:06 UTC
Message-ID: <xmqq4kv59xlg.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20200303040506.241376-1-emilyshaffer@google.com>

Emily Shaffer <emilyshaffer@google.com> writes:

Show 14 quoted lines

> If there is no worktree at present, we can still hint the user about
> Git's current directory by showing them the absolute path to the Git
> directory. Even though the Git directory doesn't make it as easy to
> locate the worktree in question, it can still help a user figure out
> what's going on while developing a script.
>
> This fixes a segmentation fault introduced in e0020b2f829.
>
> Signed-off-by: Emily Shaffer <emilyshaffer@google.com>
> ---
> This patch is built on top of es/outside-repo-errmsg-hints. I think it
> doesn't need to be, since that change is in master, though.
>
> Sounds like there's a segfault in the wild:

Thanks.  We should protect the fix with a test, no?

>  pathspec.c | 8 ++++++--
>  setup.c    | 8 ++++++--
>  2 files changed, 12 insertions(+), 4 deletions(-)