git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] submodule: use submodule repository when preparing summary

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 24, 2020, 16:12 UTC
Message-ID
<xmqq4kr08mtw.fsf@gitster.c.googlers.com>
In-Reply-To
<33de1078-5f19-e76c-2a30-1754494d1e31@gmail.com>
Derrick Stolee <stolee@gmail.com> writes:
> Perhaps the test I requested in patch 1 is only appropriate
> here? Or, maybe the test should be test_expect_failure in the
> first patch and switched to test_expect_success here?

Either is OK, but it is probably easier to read to have just one addition in 2/2 to expect succeses. Temporarily revierting with "git show ':!t' | git apply -R" before running test when you want to reallly see how the original crashed is easy and simple enough.

Thanks.
Previous: Derrick StoleeNext: Michael Forney
Message 4 of 10 in “revision: use repository from rev_info when parsing commits”
  1. 1/2 revision: use repository from rev_info when parsing commitsMichael Forney, Jun 23, 2020
  2. 2/2 submodule: use submodule repository when preparing summaryMichael Forney, Jun 23, 2020
  3. Derrick StoleeJun 24, 2020
  4. Junio C HamanoJun 24, 2020
  5. Michael ForneyJun 30, 2020
  6. Michael ForneyAug 13, 2020
  7. Eric SunshineJun 23, 2020
  8. Derrick StoleeJun 24, 2020
  9. Junio C HamanoSep 3, 2020
  10. Derrick StoleeSep 4, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.