git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] comment: fix spelling mistakes inside comments

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 29, 2020, 18:16 UTC
Message-ID
<xmqq4kpqb301.fsf@gitster.c.googlers.com>
In-Reply-To
<571792b3-e65b-e6e8-34b9-56a87a47de8d@gmail.com>
Derrick Stolee <stolee@gmail.com> writes:
Show 9 quoted lines
> I'll leave it to more experienced contributors to comment on how a
> comment-only patch fits with this section Documentation/CodingGuidelines:
>
>  - Fixing style violations while working on a real change as a
>    preparatory clean-up step is good, but otherwise avoid useless code
>    churn for the sake of conforming to the style.
>
> In my opinion, this change is not harmful, but also isn't super
> necessary. I could go either way.

Typofixes in comments has no chance of breaking things than a carelessly done code churn made in the name of cleaning up, so cost-benefit comparison is much more favourable. I'm sure that I won't be exhausted after reviewing comment-only patch as much as after reviewing code-churn only patch.

Previous: Steve KempNext: Derrick Stolee
Message 4 of 5 in “comment: fix spelling mistakes inside comments”
  1. comment: fix spelling mistakes inside commentsSteve Kemp via GitGitGadget, Jul 29, 2020
  2. Derrick StoleeJul 29, 2020
  3. Steve KempJul 29, 2020
  4. Junio C HamanoJul 29, 2020
  5. Derrick StoleeJul 29, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.