Re: [PATCH 2/2] status: print stash info with --porcelain=v2 --show-stash
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 22, 2021, 00:29 UTC
- Message-ID
- <xmqq4k99gava.fsf@gitster.g>
- In-Reply-To
- <CAPig+cQQurJuKieFcnZ8_10CaJA7vZ2kV=S+AaHVX3nhsVUG-Q@mail.gmail.com>
Eric Sunshine <sunshine@sunshineco.com> writes:
Show 19 quoted lines
>> + test_when_finished "git stash pop && git stash pop" && > > If it's indeed important to clean up the stashes when the test > finishes, then the test_when_finished() invocation should probably be > a bit more robust... > >> + git stash -- file_x && >> + git stash && > > ... since, as it is now, if an error occurs between these two > git-stash invocations or before them, then there will only be zero or > one stashes, so the double stash-pop by test_when_finished() will > itself errout out. Better, perhaps to do this: > > test_when_finished "git stash pop && git stash pop || :" && > >> + git status --porcelain=v2 --branch --show-stash --untracked-files=no >actual && >> + test_cmp expect actual >> +'
There is no "I do not care what is in the stash right now, just clear all"?