Re: [PATCH v2 04/10] sparse-index: introduce partially-sparse indexes
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 20, 2022, 18:23 UTC
- Message-ID
- <xmqq4k1khxl1.fsf@gitster.g>
- In-Reply-To
- <0b2215e1-7f12-ed0d-b7bf-03648b19e30a@github.com>
Derrick Stolee <derrickstolee@github.com> writes:
Show 7 quoted lines
>> Also these names being in cache.h and visible everywhere is somewhat >> worrying. Other CPP macros and enum constants in the file have >> names that are prepared to be truly global, but COMPLETELY_FULL and >> COLLAPSED do not hint that they are about sparse-index state as >> strongly as PARTIALLY_SPARSE does. > > Would prepending with "INDEX_" be sufficient?
Yeah, index-collapsed, index-expanded, etc., sounds distinctive enough. Sorry, but I cannot think of a good phrase for partially expanded case that is short, succinct and would go well with the fully expanded and fully collapsed cases.
Thanks.