git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] bugreport: add missing closing bracket in usage line

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 16, 2022, 16:04 UTC
Message-ID
<xmqq4jx7joez.fsf@gitster.g>
In-Reply-To
<pull.1329.git.git.1663326823401.gitgitgadget@gmail.com>
"Fangyi Zhou via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 27 quoted lines
> From: Fangyi Zhou <me@fangyi.io>
>
> Signed-off-by: Fangyi Zhou <me@fangyi.io>
> ---
>     bugreport: add missing closing bracket in usage line
>     
>     Signed-off-by: Fangyi Zhou me@fangyi.io
>
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1329%2Ffangyi-zhou%2Fbugreport-usage-fix-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1329/fangyi-zhou/bugreport-usage-fix-v1
> Pull-Request: https://github.com/git/git/pull/1329
>
>  builtin/bugreport.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/bugreport.c b/builtin/bugreport.c
> index 530895be55f..a4a5a88840d 100644
> --- a/builtin/bugreport.c
> +++ b/builtin/bugreport.c
> @@ -60,7 +60,7 @@ static void get_populated_hooks(struct strbuf *hook_info, int nongit)
>  }
>  
>  static const char * const bugreport_usage[] = {
> -	N_("git bugreport [-o|--output-directory <file>] [-s|--suffix <format>] [--diagnose[=<mode>]"),
> +	N_("git bugreport [-o|--output-directory <file>] [-s|--suffix <format>] [--diagnose[=<mode>]]"),
>  	NULL
>  };

OK, this came from aac0e8ff (builtin/bugreport.c: create '--diagnose' option, 2022-08-12), which gets the SYNOPSIS in the documentation right but misses the usage text.

An identical fix already exists as 63407051 (doc txt & -h consistency: add missing "]" to bugreport "-h", 2022-09-05).

It may help the project more to help move the topic that contains it forward by reviewing them, than independently coming up with an identical fix. The topic with the existing fix appears at

  https://lore.kernel.org/git/cover-00.34-00000000000-20220902T092734Z-avarab@gmail.com/
Thanks.
Previous: Fangyi Zhou via GitGitGadgetNext: Fangyi Zhou
Message 2 of 3 in “bugreport: add missing closing bracket in usage line”
  1. bugreport: add missing closing bracket in usage lineFangyi Zhou via GitGitGadget, Sep 16, 2022
  2. Junio C HamanoSep 16, 2022
  3. Fangyi ZhouSep 16, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.