Re: [PATCH v2 00/10] run-command API: add run_command_{l,sv}_opt()

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 18, 2022, 09:11 UTC
Message-ID: <xmqq4jw1wl6z.fsf@gitster.g>
In-Reply-To: <cover-v2-00.10-00000000000-20221017T170316Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> This series provides a more idiomatic set of run-command API helpers
> to match our current use-cases for run_command_v_opt(). See v1[1] for
> a more general overview.

Hmph... I somehow thought that the concensus is rather try the complete opposite approach shown by René's patch to lose the use of run_command_v_opt() by replacing it with run_command(&args), with args.v populated using strvec_pushl() and other strvec API functions.

One of the reasons I would prefer to see us moving in that direction was because the first iteration of this series was a good demonstration of the relatively limited usefulness of _l_opt() variant and also it seemed to be error prone to use it.