Re: [PATCH] Makefile: use sha1collisiondetection by default on OSX and Darwin

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 20, 2022, 23:26 UTC
Message-ID: <xmqq4jvyqdof.fsf@gitster.g>
In-Reply-To: <patch-1.1-1f4e39be97b-20221020T225305Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> Junio: I see in the meantime you've queued your own
> https://lore.kernel.org/git/cover-v3-0.9-00000000000-20221020T223946Z-avarab@gmail.com/;
> which is currently in "seen".

Yes, as I said, I intend to merge it to 'next' in tomorrow's pushout, and then fast track all three topics (Peff's "-O0", Eric/Ævar's "use git_SHA_CTX abstraction", and "osx-clan uses sha1dc") down to 'master'. As you chose to make this topic hostage to the other multi-part topic, which is likely to be slowed down and require rerolls for typofixes and possible bikeshedding, by the time this topic becomes ready, it is likely that it would already be in 'master' and you'd have to rebase on that.

Isn't this step of much higher importance than the other multi-part topic? I do not see why you chose to take it a hostage to the other one. Let's all learn to give priorities to produce sufficiently focused fixes that also sufficiently cover important issues. Frills and niceties can come on top later.