git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] t: run tests from a normalized working directory

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 3, 2025, 18:22 UTC
Message-ID
<xmqq4iwwk7mc.fsf@gitster.g>
In-Reply-To
<08b9b990-9ddc-740e-99ab-82d09fb30ef3@chromium.org>
Mark Mentovai <mark@chromium.org> writes:
Show 20 quoted lines
> Torsten Bögershausen wrote:
>> On Mon, Jun 02, 2025 at 02:32:35PM -0700, Junio C Hamano wrote:
>>> ...
>>> Yes.  You need to specify what you are canonicalizing to, and once
>>> you are going to do so, there is no need for that heavy verb, i.e.
>>> you do not need to say "canonicalize it to realpath"---you say "turn
>>> it into realpath" and you convey what you want to say just fine.
>>>
>> Re-reading the help for realpath() and pwd, would this makes sense:
>> t: run tests from an absolute pathname
> ...
> Making a path absolute is a different transformation than what is at
> issue here. You may have been misled by the fact that pwd -P and
> realpath both make paths absolute in addition to performing symbolic
> link resolution. The latter is what's operative here.
>
> As I've explained, the paths in question are already absolute in git's
> test suite today, even without the proposed change. It's not correct
> to summarize the change as making paths absolute, when that's neither
> changing nor the crux of the problem.
Absolutely ;-)

"normalized" does invite "normalize to what standard" question, but as you mentioned in an earlier post, "realpath" is a bit dense for those who don't read realpath(3) manual pages, and "symlink-resolved file path" is quite mouthful even though it might be understandable.

Let me merge it down with the commit title as-is and then cook it in 'next' during the -rc period.

Thanks.
Previous: Mark Mentovai
Message 19 of 19 in “t7900: use pwd -P in macOS maintenance test”
  1. t7900: use pwd -P in macOS maintenance testMark Mentovai, May 23, 2025
  2. Eric SunshineMay 23, 2025
  3. Junio C HamanoMay 23, 2025
  4. Eric SunshineMay 23, 2025
  5. Junio C HamanoMay 23, 2025
  6. Mark MentovaiMay 24, 2025
  7. Junio C HamanoMay 27, 2025
  8. Mark MentovaiMay 23, 2025
  9. Eric SunshineMay 23, 2025
  10. t: run tests from a normalized working directoryMark Mentovai, May 28, 2025
  11. Torsten BögershausenMay 28, 2025
  12. Junio C HamanoMay 30, 2025
  13. Torsten BögershausenMay 31, 2025
  14. Junio C HamanoJun 1, 2025
  15. Mark MentovaiJun 2, 2025
  16. Junio C HamanoJun 2, 2025
  17. Torsten BögershausenJun 3, 2025
  18. Mark MentovaiJun 3, 2025
  19. Junio C HamanoJun 3, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.