Re: [PATCH v3] send-email: validate charset name in 8bit encoding prompt

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 26, 2026, 19:06 UTC
Message-ID: <xmqq4in32ulj.fsf@gitster.g>
In-Reply-To: <xmqq8qcf2vk8.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 16 quoted lines

> Shreyansh Paliwal <shreyanshpaliwalcmsmn@gmail.com> writes:
>
>> diff --git a/git-send-email.perl b/git-send-email.perl
>> index cd4b316ddc..3230b80701 100755
>> --- a/git-send-email.perl
>> +++ b/git-send-email.perl
>> @@ -23,6 +23,7 @@
>>  use Git::LoadCPAN::Error qw(:try);
>>  use Git;
>>  use Git::I18N;
>> +use Encode qw(find_encoding);
>
> I wonder how common is this module already installed on users'
> systems (not asking "how widely available"---which is "can users
> easily make it work?", but asking "would this work out of box with
> what users already have?").

Answering my own question: "yes".

We use Encode::find_encoding as well as Encode::{de,en}code in gitweb and git-svn, so it is very likely that anybody who has a full installation of Git would already have it on their system. Also Encode.pm is distributed as part of Perl itself, if I am not mistaken.