Re: [PATCH 0/2] packfile URIs: support concurrent downloads
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 13, 2026, 22:48 UTC
- Message-ID
- <xmqq4ii2wlo1.fsf@gitster.g>
- In-Reply-To
- <alVn7UWvdWRAG-Vv@com-76773>
Ted Nyman <tnyman@openai.com> writes:
Show 20 quoted lines
> Packfile URI downloads currently stage a pack at > objects/pack/pack-<hash>.pack.temp. Two Git processes fetching the same > pack into one object database can append to that file concurrently, > which can corrupt the temporary pack or cause a resume request at EOF. > > The first patch gives each direct packfile URI download a private > temporary file. Ordinary dumb HTTP pack requests retain their existing > resumable staging behavior. A later packfile URI retry starts a new > download. > > The second patch handles the related .keep race. When another process > has already created the keep file, index-pack reports "pack<TAB><hash>" > instead of "keep<TAB><hash>". Accept both successful forms and remove > only keep files created by the current process. > > Each patch adds a regression test for its respective race. > > Ted Nyman (2): > http: use unique tempfiles for packfile URI downloads > fetch-pack: accept "pack" output for packfile URIs
This cover letter has
Message-ID: <alVn7UWvdWRAG-Vv@com-76773>
but in the header of [PATCH 1/2] has
Message-ID: <alVn-QmK3K91_tkH@com-76773>
References: <cover.1783982021.git.tnyman@openai.com>
In-Reply-To: <cover.1783982021.git.tnyman@openai.com>Similarly, [PATCH 2/2] has
Message-ID: <alVoA5-fDDPwKPZZ@com-76773>
References: <cover.1783982021.git.tnyman@openai.com>
In-Reply-To: <cover.1783982021.git.tnyman@openai.com>And "b4 am" seems to be having problem grabbing the patchset X-<.