git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] revision: fix --no-walk path filtering regression

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 16, 2026, 17:59 UTC
Message-ID
<xmqq4ihyhl2e.fsf@gitster.g>
In-Reply-To
<pull.2181.git.1784198879711.gitgitgadget@gmail.com>

"Kristofer Karlsson via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 41 quoted lines
> From: Kristofer Karlsson <krka@spotify.com>
>
> Since dd4bc01c0a (revision: use priority queue for non-limited
> streaming walks, 2026-05-27), "git rev-list --no-walk <commit>
> -- <path>" ignores the path arguments and outputs all commits
> regardless of whether they touch the given paths.
>
> That commit introduced a REV_WALK_NO_WALK enum value to separate
> --no-walk from the streaming walk in get_revision_1(). The new
> case skips process_parents(), which is correct for not enqueuing
> parents, but also skips try_to_simplify_commit() which
> process_parents() calls to evaluate whether each commit touches
> the given paths.
>
> Add a call to try_to_simplify_commit() for the
> REV_WALK_NO_WALK case, folding it into the existing
> REV_WALK_REFLOG case which already does the same.
>
> Add tests for --no-walk path filtering to t6017. The
> "single commit, match" test is defensive and passes without
> the fix, while the other two fail without it.
>
> Reported-by: Peter Colberg <pcolberg@redhat.com>
> Signed-off-by: Kristofer Karlsson <krka@spotify.com>
> ---
>     revision: fix --no-walk path filtering regression
>     
>     Fix for a regression reported by Peter Colberg [1] where git rev-list
>     --no-walk <commit> -- <path> ignores path arguments since dd4bc01c0a.
>     
>     Verified against linux.git with the exact example from the report:
>     
>     git rev-list --topo-order v7.0..v7.1 -- drivers/gpu/drm/ |
>     git rev-list --stdin --no-walk=unsorted -- ':!drivers/gpu/drm/'
>     
>     
>     Without fix: 2026 commits (all pass through unfiltered) With fix: 146
>     commits (correctly filtered)
>     
>     [1]
>     https://lore.kernel.org/git/CAL71e4NjDTHbKR8z7pSrPpzDrX19JOTR04sArm7P=m5ivqkskA@mail.gmail.com/T/#u

OK. Without this fix, a commit that applied this patch (which does not touch Makefile) shows the commit message in

    $ git show HEAD -- Makefile
but with this fix, just like Git 2.54 did, the command stays silent.
Will queue.  Thanks.
Previous: Kristofer Karlsson via GitGitGadgetNext: Peter Colberg
Message 2 of 3 in “revision: fix --no-walk path filtering regression”
  1. revision: fix --no-walk path filtering regressionKristofer Karlsson via GitGitGadget, Jul 16, 2026
  2. Junio C HamanoJul 16, 2026
  3. Peter ColbergJul 16, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.