Re: [PATCH] completion: complete paths for git send-email

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 22, 2026, 15:32 UTC
Message-ID: <xmqq4ihrt4yt.fsf@gitster.g>
In-Reply-To: <C9564DC6-6B68-46CA-A339-1A1774AFA7C0@gmail.com>

Ben Knoble <ben.knoble@gmail.com> writes:

Show 9 quoted lines

>> As to the tests, using 40-hex is misleading, and 0-branch as you
>> said would be sufficient to reproduce and demonstrate the issue, and
>> that your code change fixes it.
>> 
>> Ben, anything I missed?
>> 
>> Thanks.
>
> Not from my end, though SZEDER’s review merits some thinking.

I agree that presenting both refs and paths cleanly will require a much better structure than a flat list. I also agree that hiding paths when we have ref matches may give us a cleaner layout than mixing them alphabetically into a single, flat list. While I am still not convinced it is the best way, at least that is the principle current completion implementations use for other commands, and it makes sense to model the updated completion for send-email after it.

That said, since I never feed refs to send-email myself, 'if we have matches with refs, do not show paths at all' rule makes send-email completion completely useless, at least to me.

> Traveling the next week+; replies may be slower (than usual, hah).

Have a great trip, and have fun!

Thanks.