Re: [PATCH] exec_cmd: RUNTIME_PREFIX on OpenBSD systems
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 21, 2026, 16:57 UTC
- Message-ID
- <xmqq4ifio83d.fsf@gitster.g>
- In-Reply-To
- <de116c51-b538-44b7-87d9-653b84a55088@comstyle.com>
Brad Smith <brad@comstyle.com> writes:
Show 22 quoted lines
> On 2026-09-17 9:45 a.m., Junio C Hamano wrote: >> Brad Smith <brad@comstyle.com> writes: >> >>> Enable Git to resolve its own binary location using getexecpath(). >> That may not be incorrect information per-se, but lacks critical >> bits. Natural initial questions that come to my mind are... >> >> Why would one want to use getexecpath() over whatever OpenBSD >> ports of Git have been using happily? Is the old way being >> removed? Is the new way being more accurate? In what >> situations does the difference matter? Is everybody on OpenBSD >> able to use this new function? Do only certain, and/or >> presumably later, verions of OpenBSD have it? How widely is it >> available? How long has it been available? > > It's a long awaited API for such functionality on OpenBSD. Otherwise there > hasn't really been a means of doing so and one which has been using happily. > The proper API I would say is one which works and is more accurate. One > which works the same everywhere where as the pile of hacks has different > results and not happily either. > > The API is new. The config.mak.uname check looks for 8.0 and newer.
OK, all of the above were missing from the proposed log message that should be placed when v2 patch is prepared. They've happily been using argv[0] as an approximate (which may be OK as long as we do not lie to ourselves but not as nice), and now they are going to have a proper syscall for the information, finally. You would also need to answer the last few questions I asked in the proposed log message of v2, but I thought 8.0 is not yet released?
Thanks.