git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/3] patch-id: make it stable against hunk reordering

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 28, 2014, 18:20 UTC
Message-ID
<xmqq38i2b2x2.fsf@gitster.dls.corp.google.com>
In-Reply-To
<1396009159-2078-1-git-send-email-mst@redhat.com>
"Michael S. Tsirkin" <mst@redhat.com> writes:
> Patch id changes if you reorder hunks in a diff.

Reording "files" is fine, and as we discussed, having multiple patches that touch the same path is fine, but do not sound as if you are allowing to reorder "hunks" inside a single patch that touch a single file.

Thanks.
Previous: Michael S. TsirkinNext: Junio C Hamano
Message 4 of 8 in “patch-id: make it stable against hunk reordering”
  1. 1/3 patch-id: make it stable against hunk reorderingMichael S. Tsirkin, Mar 28, 2014
  2. 2/3 patch-id: document new behaviourMichael S. Tsirkin, Mar 28, 2014
  3. 3/3 patch-id-test: test new --stable and --unstable flagsMichael S. Tsirkin, Mar 28, 2014
  4. Junio C HamanoMar 28, 2014
  5. Junio C HamanoMar 28, 2014
  6. Michael S. TsirkinMar 30, 2014
  7. Junio C HamanoMar 28, 2014
  8. Junio C HamanoMar 28, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.