Re: [PATCH v2 0/9] Introduce publish tracking branch
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 10, 2014, 21:21 UTC
- Message-ID
- <xmqq38hkx4lr.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <1397156686-31349-1-git-send-email-felipe.contreras@gmail.com>
A handful of minimum tweaks [*1*] here and there were necessary in order to queue the series on 'pu', but to me, the feature looked like quite a straight-forward addition.
I'd be dropping the jk/branch-at-publish-rebased from 'pu', at least tentatively, as that one was primarily Peff giving Ram a base to build on top to achieve essentially the same thing as this series does. I didn't bother to check if this series could have reused some from that series (primarily because I was short of time, had to take the work laptop to service, etc. etc.) before doing so.
I didn't think too deeply about the workflow ramifications of this series brings in, either---that is left for the reviewers Cc'ed on the patches.
[Footnote]
*1* Things like these:
- the context in builtin/push.c has already changed at the tip of 'master' (we already pretend to be Git 2.0) and the patch text needed to be adjusted.
- an instance of cast to "(char*)" fixed to "(char *)".
- t/t5529 is already used by other topics, renaming the new test to t/t5534-push-publish.sh.
- !prefixcmp() is already removed for Git 2.0, replacing its use with starts_with().