Re: Project idea: strbuf allocation modes
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 19, 2014, 00:55 UTC
- Message-ID
- <xmqq38hab0js.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <5351854E.1080602@alum.mit.edu>
Michael Haggerty <mhagger@alum.mit.edu> writes:
Show 20 quoted lines
> On 04/18/2014 07:21 PM, Junio C Hamano wrote: >> Michael Haggerty <mhagger@alum.mit.edu> writes: >> >>> The Idea >>> ======== >>> >>> I would like to see strbuf enhanced to allow it to use memory that it >>> doesn't own (for example, stack-allocated memory), while (optionally) >>> allowing it to switch over to using allocated memory if the string grows >>> past the size of the pre-allocated buffer. >> >> I'd like to see these characteristics, but I would want to see that >> this is done entirely internally inside the strbuf implementation >> without any API impact, other than the initialisation. I do not >> ... > > I think that's exactly what I described. The only thing that would have > to change in the strbuf behavior (aside from initialization) is that a > buffer-growing operation might die if the string would grow outside of > the bounds of the existing buffer when STRBUF_FIXED_MEMORY is set.
Yup, we are in agreement ;-)
More seriously, sorry for sounding as if I was objecting. I should have edited s/but/and/ before sending my response out.
Thanks.