Re: [PATCH 2/5] implement submodule config cache for lookup of submodule names

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 12, 2014, 21:58 UTC
Message-ID: <xmqq38f96b9f.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20140605060750.GC23874@sandbox-ub>

Heiko Voigt <hvoigt@hvoigt.net> writes:

> ...
> +static int is_cache_init = 0;

Please don't initialise variables in the .bss to zero by hand.

Show 12 quoted lines

> + ...
> +	warning("%s:.gitmodules, multiple configurations found for "
> +			"submodule.%s.%s. Skipping second one!",
> +			commit_string, name, option);
> +}
> + ...
> +		if (strcmp(value, "untracked") && strcmp(value, "dirty") &&
> +		    strcmp(value, "all") && strcmp(value, "none")) {
> +			warning("Invalid parameter \"%s\" for config option "
> +					"\"submodule.%s.ignore\"", value, var);
> +			goto release_return;
> +		}

These two look inconsistent in different ways. I think we typically quote the names like so:

	warning("I have trouble with variable '%s' somehow", var);