git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/2] git_connect: set ssh shell command in GIT_SSH_CMD

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 9, 2014, 17:32 UTC
Message-ID
<xmqq389se0up.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20141109123934.GA50956@melamine.cuivre.fr.eu.org>
Thomas Quinot <thomas@quinot.org> writes:
> Could also be GIT_SSH_SHELLCMD, to denote that this is a *shell*
> command...

Whatever. I loathe the CMD abbreviation, though. Why spell out SHELL but not COMMAND? I.e. GIT_SSH_[SHELL_]COMMAND

Show 7 quoted lines
>> Parsing complications aside, you cannot even know in git which ssh is
>> going to be run until the shell code is executed. I think either we have
>> to leave the responsibility for munging "-p" into "-P" on the side of
>> the user's shell snippet
>
> That sounds like a reasonable approach, and leaves us with the simpler
> change (that splitting circuitry was admittely a bit awkward...)

It does not make sense to special case "plink" at the level of this mechanism where the spawned command line does not even have to invoke any "ssh" and its derivatives, so I fully agree that choosing between -P and -p should be the responsibility of whoever is using this mechanism.

Thanks.
Previous: Thomas QuinotNext: Thomas Quinot
Message 8 of 15 in “git_connect: allow passing arguments to ssh in GIT_SSH_ARGS”
  1. git_connect: allow passing arguments to ssh in GIT_SSH_ARGSThomas Quinot, Nov 8, 2014
  2. Jeff KingNov 8, 2014
  3. Thomas QuinotNov 8, 2014
  4. 1/2 git_connect: set ssh shell command in GIT_SSH_CMDThomas Quinot, Nov 8, 2014
  5. Jeff KingNov 9, 2014
  6. Thomas QuinotNov 9, 2014
  7. git_connect: set ssh shell command in GIT_SSH_CMDThomas Quinot, Nov 9, 2014
  8. Junio C HamanoNov 9, 2014
  9. Thomas QuinotNov 9, 2014
  10. Junio C HamanoNov 9, 2014
  11. git_connect: set ssh shell command in GIT_SSH_COMMANDThomas Quinot, Nov 9, 2014
  12. Jeff KingNov 10, 2014
  13. Thomas QuinotNov 10, 2014
  14. Junio C HamanoNov 10, 2014
  15. 2/2 git_connect: when using GIT_SSH_CMD, check for plink in argv[0] onlyThomas Quinot, Nov 8, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.