git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] dumb-http: do not pass NULL path to parse_pack_index

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 27, 2015, 20:46 UTC
Message-ID
<xmqq386wkl3f.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20150127201921.GA24365@hashpling.org>
Charles Bailey <charles@hashpling.org> writes:
Show 10 quoted lines
> On Tue, Jan 27, 2015 at 03:02:27PM -0500, Jeff King wrote:
>> Discovery and tests by Charles Bailey <charles@hashpling.org>.
>> 
>> Signed-off-by: Jeff King <peff@peff.net>
>> ---
>> I'm happy to flip the authorship on this. You have more lines in it than
>> I do. :)
>
> No, I'm happy with you taking the blame/praise for this, it's definitely
> your fix.

Looks good (rather, makes the original look obviously broken and makes me wonder why our review process did not catch that bogus NULL in the first place).

Thanks, both.
Previous: Charles Bailey
Message 6 of 6 in “Add failing test for fetching from multiple packs over dumb httpd”
  1. Add failing test for fetching from multiple packs over dumb httpdCharles Bailey, Jan 27, 2015
  2. Jeff KingJan 27, 2015
  3. Charles BaileyJan 27, 2015
  4. dumb-http: do not pass NULL path to parse_pack_indexJeff King, Jan 27, 2015
  5. Charles BaileyJan 27, 2015
  6. Junio C HamanoJan 27, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.