Re: [PATCH 2/2] log: "--no-show-signature" commmand-line option

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 6, 2016, 18:50 UTC
Message-ID: <xmqq37oqxib8.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160605153933.15231-3-mehul.jain2029@gmail.com>

Mehul Jain <mehul.jain2029@gmail.com> writes:

Show 5 quoted lines

> If "log.showSignature=true", then there is no way to override it using
> command line switch.
>
> Teach git-log and related commands about "--no-showSignature" command
> line option.

Doesn't that suggest that 1/2 alone will cause users problems? The users can by mistake set the configuration variable and there is no way for them to override it from the command line.

If you swap the order of the two patches, the topic makes more sense. I.e.

    [1/2] log: add "--no-show-signature" command line option

makes "git log --show-signature --no-show-signature" to run without GPG checks, which by itself is a worthy change. And then

    [2/2] log: add log.showSignature configuration variable

makes revs->show_signature default to the configured value, instead of always initializing it to false.