Re: [PATCH] gitweb: escape link body in format_ref_marker

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 1, 2016, 19:54 UTC
Message-ID: <xmqq37mojme2.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <51785fbd-6858-c9b2-7f59-eaf7bd3ea394@gmail.com>

Jakub Narębski <jnareb@gmail.com> writes:

> Good catch!
>
> Acked-by: Jakub Narębski <jnareb@gmail.com>

Sigh; the contents may be good but the patch is unusable as-is because of heavy whitespace damage.

I'll fix it up.  Thanks, both.

Show 19 quoted lines

>> ---
>>  gitweb/gitweb.perl | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
>> index 2fddf75..33d701d 100755
>> --- a/gitweb/gitweb.perl
>> +++ b/gitweb/gitweb.perl
>> @@ -2090,7 +2090,7 @@ sub format_ref_marker {
>>                                 -href => href(
>>                                         action=>$dest_action,
>>                                         hash=>$dest
>> -                               )}, $name);
>> +                               )}, esc_html($name));
>> 
>>                         $markers .= " <span
>> class=\"".esc_attr($class)."\" title=\"".esc_attr($ref)."\">" .
>>                                 $link . "</span>";
>>