Re: [PATCH v2 7/7] blame: actually use the diff opts parsed from the command line

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 7, 2016, 17:58 UTC
Message-ID: <xmqq37lboaml.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <a6d9e9a7-76c4-5b26-0b49-55698369180d@alum.mit.edu>

Michael Haggerty <mhagger@alum.mit.edu> writes:

> The reason that I would prefer to change `blame` as part of this patch
> series is that I think it would be disconcerting for `git diff` and `git
> blame` to use different heuristics when computing diffs. It would make
> their output inconsistent.

I do think it is the right thing to do. With your shifting heuristics, "git diff" would attribute an addition of a whole block more correctly, e.g.

        +foo {
        +	bar
        +       baz
	+}

instead of attributing the tail of the new thing to the old author, and the "blame" should take advantage of the better heuristics as well.