Re: [PATCH v7 10/10] convert: add filter.<driver>.process option

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 15, 2016, 20:04 UTC
Message-ID: <xmqq37l1nd42.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <5E675A29-628F-4076-A5D9-E359CCF04295@gmail.com>

Lars Schneider <larsxschneider@gmail.com> writes:

Show 5 quoted lines

> Wouldn't that complicate the pathname parsing on the filter side?
> Can't we just define in our filter protocol documentation that our 
> "pathname" packet _always_ has a trailing "\n"? That would mean the 
> receiver would know a packet "pathname=ABC\n\n" encodes the path
> "ABC\n" [1].

That's fine, too. If you declare that pathname over the protocol is a binary thing, you can also define that the packet does not have the terminating \n, i.e. the example encodes the path "ABC\n\n", which is also OK ;-)

As long as the rule is clearly documented, easy for filter implementors to follow it, and hard for them to get it wrong, I'd be perfectly happy.

Thanks.