Re: [PATCH] mingw: follow-up to "replace isatty() hack"

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 18, 2017, 21:30 UTC
Message-ID: <xmqq37gg3vjy.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <c329c981-2b92-13b5-0561-d1d2e3fa2803@kdbg.org>

Johannes Sixt <j6t@kdbg.org> writes:

Show 15 quoted lines

>>> -	dup2(new_fd, fd);
>>>  	if (console == handle)
>>>  		console = duplicate;
>>> -	handle = INVALID_HANDLE_VALUE;
>>> +	dup2(new_fd, fd);
>>>
>>>  	/* Close the temp fd.  This explicitly closes "new_handle"
>>>  	 * (because it has been associated with it).
>>>
>
> Looks good and obviously correct (FLW). I can offer a
>
> Reviewed-by: Johannes Sixt <j6t@kdbg.org>
>
> but it will take a day or two until I can test the patch.

I think a Reviewed-by is good enough, as the original

<2ce6060b891f8313cc63a95a9cba9064b7f82eb8.1482448531.git.johannes.schindelin@gmx.de>

already has "Tested-by" to indicate that as a whole this have been tested. The "follow-up" we are commenting on was made out of that original to incrementally update the older version that was queued and merged to 'master' 3 weeks ago.

Thanks.