Re: [PATCH v3 4/4] urlmatch: allow globbing for the URL host part

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 26, 2017, 20:49 UTC
Message-ID: <xmqq37g54kdz.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <xmqq7f5h4kng.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 7 quoted lines

> +	while (url_len && pat_len) {
> +		const char *url_next = end_of_token(url, '.', url_len);
> +		const char *pat_next = end_of_token(pat, '.', pat_len);
> + ...
>  	}
>  
> +	return 1;

Embarrassing.  The last one must be "have they both run out?" i.e.

	return (!url_len && !pat_len);