Re: [PATCH v1 0/3] travis-ci: build docs with asciidoctor
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 13, 2017, 22:41 UTC
- Message-ID
- <xmqq37dcorr7.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20170411083309.58315-1-larsxschneider@gmail.com>
Lars Schneider <larsxschneider@gmail.com> writes:
> this is a mini series to build the documentation with asciidoctor in > addition to asciidoc on Travis-CI.
Overall, this looks sensible. I didn't spot anything questionable other than a minor style nit, i.e. write these
make doc USE_ASCIIDOCTOR=1
make -j2 doc USE_ASCIIDOCTOR=1more like this
make USE_ASCIIDOCTOR=1 doc
make -j2 USE_ASCIIDOCTOR=1 docHaving said that, I wonder if we get some interesting results out of building the documentation twice, though. By looking at the Travis log with timestamps, we probably can see how long each build takes, but that is much less interesting than learning if new versions of text used mark-up that does not format correctly on one or the other (i.e. catch documentation breakage early in each CI run), for example. I have an impression that neither AsciiDoc nor AsciiDoctor "fails" in an obvious way that "make" can notice (i.e. they often just silently produce nonsense output when fed a malformed input instead).
Thanks.