Is t5601 flaky for anybody else?
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 17, 2017, 05:04 UTC
- Message-ID
- <xmqq376ipdpx.fsf@gitster.mtv.corp.google.com>
I seem to be seeing sporadic errors with this test, and today I got annoyed enough to do
cd t && while sh t5601-clone.sh -i -v; do :; done
I saw an error from "cp" saying "plink.exe - text file busy" or something like that at around test #45; here is an workaround that seems to work (the above loop is spinning without problem for several minutes now).
t/t5601-clone.sh | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/t/t5601-clone.sh b/t/t5601-clone.sh index 9c56f771b6..50e40abb11 100755 --- a/t/t5601-clone.sh +++ b/t/t5601-clone.sh @@ -308,6 +308,7 @@ test_expect_success 'clone checking out a tag' ' setup_ssh_wrapper () { test_expect_success 'setup ssh wrapper' ' + rm -f "$TRASH_DIRECTORY/ssh-wrapper$X" && cp "$GIT_BUILD_DIR/t/helper/test-fake-ssh$X" \ "$TRASH_DIRECTORY/ssh-wrapper$X" && GIT_SSH="$TRASH_DIRECTORY/ssh-wrapper$X" && @@ -318,6 +319,7 @@ setup_ssh_wrapper () { } copy_ssh_wrapper_as () { + rm -f "${1%$X}$X" && cp "$TRASH_DIRECTORY/ssh-wrapper$X" "${1%$X}$X" && GIT_SSH="${1%$X}$X" && export GIT_SSH