git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv4 7/7] builtin/describe.c: describe a blob

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 16, 2017, 02:04 UTC
Message-ID
<xmqq375fx9ly.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<CAGZ79kY109yTQESzVg69nsibucAhvP0m+vKUH21xB9m7WTGaFg@mail.gmail.com>
Stefan Beller <sbeller@google.com> writes:
>     grep "fatal: test-blob-1 is neither a commit nor blob" actual

OK, that might be somewhat unsatisfying from end-user's point of view (logically "test-blob-1" is already a name based on the 'graph relations' that is satisfactory).

	[side note] should that grep become test_i18ngrep?

If this machinery is to find an object that is *bad* (in the sense in one of your earlier messages), I suspect it may be quite easy to use the new mechanism added by the series to also locate a tree object and report "that tree appears in this commit at this path" and it would be equally useful as the feature to find a blob.

Thanks.
Previous: Stefan BellerNext: Junio C Hamano
Message 16 of 17 in “[PATCHv4 0/7] describe a blob”
  1. Stefan BellerNov 15, 2017
  2. 1/7 t6120: fix typo in test nameStefan Beller, Nov 15, 2017
  3. 3/7 revision.h: introduce blob/tree walking in order of the commitsStefan Beller, Nov 15, 2017
  4. Jonathan TanNov 15, 2017
  5. 4/7 builtin/describe.c: rename `oid` to avoid variable shadowingStefan Beller, Nov 15, 2017
  6. 2/7 list-objects.c: factor out traverse_trees_and_blobsStefan Beller, Nov 15, 2017
  7. 5/7 builtin/describe.c: print debug statements earlierStefan Beller, Nov 15, 2017
  8. Jonathan TanNov 15, 2017
  9. 6/7 builtin/describe.c: factor out describe_commitStefan Beller, Nov 15, 2017
  10. Jonathan TanNov 15, 2017
  11. 7/7 builtin/describe.c: describe a blobStefan Beller, Nov 15, 2017
  12. Jonathan TanNov 15, 2017
  13. Stefan BellerNov 16, 2017
  14. Junio C HamanoNov 16, 2017
  15. Stefan BellerNov 16, 2017
  16. Junio C HamanoNov 16, 2017
  17. Junio C HamanoNov 17, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.