Re: [PATCH v5 00/10] Filter combination

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 28, 2019, 16:05 UTC
Message-ID: <xmqq36jtae5w.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <cover.1561675151.git.matvore@google.com>

Matthew DeVore <matvore@google.com> writes:

> This applies suggestions made by Jonathan Tan, as well as fixes a
> Coccinelle-breaking error in strbuf usage, and makes an additional string
> localizable.

OK, so the convention is that errbuf has already translated string, so the call to die() made in a fairly high point in the callchain do not use _(). I looked at the new _() in deeper level of the callchain this round adds relative to the previous one, and they all looked sensible.

The helper function should_delegate is now gone---it had only one callsite in the previous round, so I suspect the resulting code would be the same either way with moderately decent compilers.

Will queue; thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.