Re: [PATCH 1/2] grep: make sure NO_LIBPCRE1_JIT disable JIT in PCRE1

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 26, 2019, 18:54 UTC
Message-ID: <xmqq36hnhi4n.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190825182223.76288-2-carenas@gmail.com>

Carlo Marcelo Arenas Belón  <carenas@gmail.com> writes:

> e87de7cab4 ("grep: un-break building with PCRE < 8.32", 2017-05-25)
> added a restriction for JIT support that is no longer needed after
> pcre_jit_exec() calls were removed.

I was initially puzzled by this statement, until I realized that the removal of pcre_jit_exec() happens in the topic still in flight that this patch builds on top of, namely 685668fa ("grep: stop using a custom JIT stack with PCRE v1", 2019-07-26).

So the logic is that because we do no longer call pcre_jit_exec() that weren't available between 8.20 and 8.32, these slightly older versions can now do JIT just like the ones post 8.32?

Thanks.  Queued.