Re: What's cooking in git.git (Sep 2019, #01; Sat, 7)
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 28, 2019, 23:31 UTC
- Message-ID
- <xmqq36ggj8ve.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20190909234715.GO11334@genre.crustytoothpaste.net>
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
Show 13 quoted lines
> On 2019-09-07 at 17:26:53, Junio C Hamano wrote: >> * bc/object-id-part17 (2019-08-19) 26 commits >> ... >> - builtin/replace: make hash size independent >> >> Preparation for SHA-256 upgrade continues. >> >> Looked mostly OK, with a possible update. >> cf. <20190820223606.GJ365197@genre.crustytoothpaste.net> > > Just to update on the status of this, I wasn't planning on a reroll, > although I'm happy to do so if folks have feedback. Opinions for or > against the current state are welcome.
I've already said that this looked mostly OK, and I think you and RRéne's "maybe adopt the use of oid_to_hex()s without using our own buffer" can come after the dust settles, so let's move this forward as-is.
That is, unless I hear otherwise in the next few days.
Thanks.