Re: [PATCH v5 3/5][Outreachy] t7102,t7201: remove whitespace after redirect operator
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 22, 2020, 05:44 UTC
- Message-ID
- <xmqq36264xx5.fsf@gitster.c.googlers.com>
- In-Reply-To
- <CAPig+cRzLpY4Pe11SQ0uux-_+x_CSVYM1FvRvDebH3TNi-bVow@mail.gmail.com>
Eric Sunshine <sunshine@sunshineco.com> writes:
Show 17 quoted lines
> On Wed, Oct 21, 2020 at 8:51 AM Charvi Mendiratta <charvi077@gmail.com> wrote: >> According to Documentation/CodingGuidelines, redirect >> operator is written with space before, but no space >> after them. >> >> Let's remove these whitespaces after redirect operators. >> >> Signed-off-by: Charvi Mendiratta <charvi077@gmail.com> >> --- >> diff --git a/t/t7102-reset.sh b/t/t7102-reset.sh >> @@ -460,14 +460,14 @@ test_expect_success 'resetting an unmodified path is a no-op' ' >> -cat > expect << EOF >> +cat >expect << EOF > > There's still a space after the '<<' operator which should be removed: > > cat >expect <<EOF
Also, this is outside any test_expect_*, which is unusual in modernized test scripts. There are many other instances of preparing expected output outside test_expect_* in this file, so we may need another patch to clean them up.
For now, within the context of this patch, let's just fix the space after the << here-doc redirection operator, as you spotted. The attached I'll squash into this patch.
Thanks.
t/t7102-reset.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git i/t/t7102-reset.sh w/t/t7102-reset.sh index a8c96bf162..07acaa2beb 100755 --- i/t/t7102-reset.sh +++ w/t/t7102-reset.sh @@ -460,7 +460,7 @@ test_expect_success 'resetting an unmodified path is a no-op' ' git diff-index --cached --exit-code HEAD ' -cat >expect << EOF +cat >expect <<EOF Unstaged changes after reset: M file2 EOF