Re: [PATCH 1/9] t/: new helper for tests that pass with ort but fail with recursive

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 26, 2020, 17:43 UTC
Message-ID: <xmqq3620g9xl.fsf@gitster.c.googlers.com>
In-Reply-To: <CABPp-BEmJA92tDymypgJqGmi=eMsvU+eP=KeTKvKcJEvFVztEA@mail.gmail.com>

Elijah Newren <newren@gmail.com> writes:

Show 14 quoted lines

>> When I wrote the patch, I was expecting something like
>>
>>         test_expect_merge_success recursive=failure,other=failure ...
>>
>> in order to merge all algorithm into single parameters.
>>
>> How about something like:
>>
>>         test_expect_merge_success exception=recursive,other ...
>>
>> Not that we have "other" algorithm to begin with.
>
> Sure, sounds great.  I wouldn't spend any time trying to make it work
> with a 3rd backend, though.

Yup. I'd appreciate if the lines become a bit shorter while at it, though.

    test_merge_both [<exception>] '<title>' '
	<body>
    '

that expects success unless otherwise told, and <exception> like "failure=recursive" can be used to tell us to expect differently, would work well?