Re: [PATCH] git-apply: add --quiet flag
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 28, 2021, 07:40 UTC
- Message-ID
- <xmqq35vac0vq.fsf@gitster.g>
- In-Reply-To
- <20210427194106.14500-1-jerry@skydio.com>
Jerry Zhang <jerry@skydio.com> writes:
> Replace OPT_VERBOSE with OPT_VERBOSITY.
While it is not an incorrect statement, it is odd to have such an implementation detail nobody cares as the first thing in the log message, though.
> This adds a --quiet flag to "git apply" so > the user can turn down the verbosity.
Sure, I think you can do "apply --no-verbose" to do the same thing without any change, but we introduced VERBOSITY to replace VERBOSE exactly so that --verbose can be countermanded with --quiet, and this patch is a good example of the application of that feature.
I wonder if this deserves a test.
Also, does "git am" have an "--quiet" option (or "--verbose" for that matter), and if so, should it pass it down to underlying "git apply" (this is not a rhetorical suggestion --- it is a genuine question---I am not particularly interested in changing "am")?
The patch text looks good.
Thanks.