Re: [PATCH v2] CodingGuidelines: explicitly allow "local" for test scripts

From: Junio C Hamano <gitster@pobox.com>
Date: May 4, 2021, 23:55 UTC
Message-ID: <xmqq35v26olz.fsf@gitster.g>
In-Reply-To: <YJHWJRYOcFEvHoD/@camp.crustytoothpaste.net>

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

> One of the main reasons the Austin Group is having trouble standardizing
> it is because some shells implement it with lexical scoping and some use
> dynamic scoping, but if we try not to make too many assumptions, we'll
> probably be okay.

Thanks for raising that one. As long as we make sure that our script would work with anybody's "local", I do not care very much. I just didn't think we want to spend the effort to explain that in the documentation and enforce it---compared to the effort, just saying "no" is certainly easier.

But if somebody wants an incremental patch on top to spell out how "local" is allowed to be used in our scripts, that's fine by me.