Re: [PATCH] t5310: drop lib-bundle.sh include

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 29, 2021, 07:04 UTC
Message-ID: <xmqq35okmhv5.fsf@gitster.g>
In-Reply-To: <YXr3+yqtXYGgaxnX@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 9 quoted lines

> Commit ddfe900612 (test-lib-functions: move function to lib-bitmap.sh,
> 2021-02-09) meant to include lib-bitmap.sh in t5310, but also includes
> lib-bundle.sh. Yet we don't use any of its functions, nor have anything
> to do with bundles. This is probably just a typo/copy-paste error, as
> lib-bundle.sh was added (correctly) to other scripts in the same series.
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> Not really hurting anything, just confusing.

Makes sense to me.

Will queue; thanks.

Show 16 quoted lines

>
>  t/t5310-pack-bitmaps.sh | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/t/t5310-pack-bitmaps.sh b/t/t5310-pack-bitmaps.sh
> index 673baa5c3c..dcf03d324a 100755
> --- a/t/t5310-pack-bitmaps.sh
> +++ b/t/t5310-pack-bitmaps.sh
> @@ -5,7 +5,6 @@ GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=master
>  export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
>  
>  . ./test-lib.sh
> -. "$TEST_DIRECTORY"/lib-bundle.sh
>  . "$TEST_DIRECTORY"/lib-bitmap.sh
>  
>  # t5310 deals only with single-pack bitmaps, so don't write MIDX bitmaps in