Re: [PATCH v2] help: make auto-correction prompt more consistent
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 16, 2021, 03:12 UTC
- Message-ID
- <xmqq35mtz1i2.fsf@gitster.g>
- In-Reply-To
- <pull.1166.v2.git.git.1639609138813.gitgitgadget@gmail.com>
"kashav madan via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 6 quoted lines
> From: Kashav Madan <kshvmdn@gmail.com> > > There are three callsites of git_prompt() that ask the user for "yes/no" > confirmation, but the one in help.c, used for auto-correction, is > formatted differently from the others. This updates that format string > to make the prompt look more consistent.
Looks much better.
The last sentence should be phrased as if we were giving an order to the codebase to "become like so", to match the style, in which our log messages are typically written (look for "imperative-mood" in Documentation/SubmittingPatches).
Thanks.
Show 15 quoted lines
> diff --git a/help.c b/help.c
> index 973e47cdc30..71444906ddf 100644
> --- a/help.c
> +++ b/help.c
> @@ -643,7 +643,7 @@ const char *help_unknown_cmd(const char *cmd)
> else if (autocorrect == AUTOCORRECT_PROMPT) {
> char *answer;
> struct strbuf msg = STRBUF_INIT;
> - strbuf_addf(&msg, _("Run '%s' instead? (y/N)"), assumed);
> + strbuf_addf(&msg, _("Run '%s' instead [y/N]? "), assumed);
> answer = git_prompt(msg.buf, PROMPT_ECHO);
> strbuf_release(&msg);
> if (!(starts_with(answer, "y") ||
>
> base-commit: e773545c7fe7eca21b134847f4fc2cbc9547fa14