Re: [PATCH] builtin/show-ref.c: avoid over-iterating with --heads, --tags

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 6, 2022, 17:07 UTC
Message-ID: <xmqq35ghaffn.fsf@gitster.g>
In-Reply-To: <af32aefc-8184-94ff-fd80-76221dc313b4@github.com>

Derrick Stolee <derrickstolee@github.com> writes:

Show 13 quoted lines

>> -	for_each_ref(show_ref, NULL);
>> +	if (heads_only || tags_only) {
>> +		if (heads_only)
>> +			for_each_fullref_in("refs/heads/", show_ref, NULL);
>> +		if (tags_only)
>> +			for_each_fullref_in("refs/tags/", show_ref, NULL);
>
> This looks a little silly if these were truly "only" (they
> could not both be true), but indeed they could both be true
> and the names are just slightly misleading.
>
> Indeed, t1403-show-ref.sh tests all combinations of these
> options.

Hmph, that is right. show-heads and show-tags, perhaps.

Thanks, both.  Queued.